[TIMOB-10507] iOS: Text/password inputs for AlertDialog #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CR Approved, looks good. |
|
FR approved, but needs one thing. The documentation should mention that beyond two buttons, the layout really breaks. (This is Apple's issue, not ours, but something we should note, especially given the sample test.) |
|
@BlainHamon updated documentation, please re-review. I can get a hand for documentation so english is not my main language and my grammar knowledge is limited. |
|
Looks good. (Sorry for the delay). CR&FR already approved. Will be manually merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation may need to be revisited. Please review.
Functional test code has been submitted to jira ticket can be found at https://jira.appcelerator.org/browse/TIMOB-10507