New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timob-10535: Android: Deprecate updateLayout, startLayout, finishLayout #2801
Conversation
Code reviewed and looks fine. A test case should still be included though that shows that the modified methods still operate correctly. Please attach test case to Jira ticket and I will functional test. |
@@ -456,6 +456,7 @@ methods: | |||
|
|||
- name: finishLayout | |||
since: "2.0.0" | |||
deprecated: {since: "2.2.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are adding support for a new key here, "notes:" Please use it to refer to the alternative API.
deprecated:
since: "2.2.0"
notes: Use the [applyProperties](Titanium.Proxy.applyProperties) method to batch-update layout properties.
(You can also use the deprecated: { since: "...", notes: "..." } form, but I think this is a little easier to read when you're including text.)
Updated. Ready for review again. |
Code reviewed and functional test passed on both runtimes. Accepted but waiting for sign off from Arthur who can merge assuming there are no issues. Docgen and validate also passed for me. |
Reviewed doc changes & validated that all looks good with new JSDuck deprecation handling. Accepted. |
timob-10535: Android: Deprecate updateLayout, startLayout, finishLayout
https://jira.appcelerator.org/browse/TIMOB-10535