Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timob-10535: Android: Deprecate updateLayout, startLayout, finishLayout #2801

Merged
merged 4 commits into from Aug 27, 2012

Conversation

pingwang2011
Copy link
Contributor

@rusticphilosopher
Copy link
Contributor

Code reviewed and looks fine. A test case should still be included though that shows that the modified methods still operate correctly. Please attach test case to Jira ticket and I will functional test.

@@ -456,6 +456,7 @@ methods:

- name: finishLayout
since: "2.0.0"
deprecated: {since: "2.2.0"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding support for a new key here, "notes:" Please use it to refer to the alternative API.

deprecated: 
    since: "2.2.0"
    notes: Use the [applyProperties](Titanium.Proxy.applyProperties) method to batch-update layout properties.

(You can also use the deprecated: { since: "...", notes: "..." } form, but I think this is a little easier to read when you're including text.)

@pingwang2011
Copy link
Contributor Author

Updated. Ready for review again.

@rusticphilosopher
Copy link
Contributor

Code reviewed and functional test passed on both runtimes. Accepted but waiting for sign off from Arthur who can merge assuming there are no issues. Docgen and validate also passed for me.

@arthurevans
Copy link
Contributor

Reviewed doc changes & validated that all looks good with new JSDuck deprecation handling. Accepted.

arthurevans pushed a commit that referenced this pull request Aug 27, 2012
timob-10535: Android: Deprecate updateLayout, startLayout, finishLayout
@arthurevans arthurevans merged commit 79e9c73 into tidev:master Aug 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants