TIMOB-7474 tiapp.xml setting to target only specific android architectur...

[billdawson]

...e (armeabi, etc.)

See JIRA for testing notes.

[joshthecoder]

I do have some concerns with specifying the ABI in the Android manifest section.
Any reason why a property tag wouldn't be a better approach? (Commented in JIRA as well).

[joshthecoder]

Should probably validate the ABI we parse from tiapp.xml. If you provide a bad value the build is successful, but the
application will crash since no binaries are packaged.

[joshthecoder]

Actually the build does fail, but the error isn't trivial to understand (file not found).

[billdawson]

Agreed, I'm going to make that change pronto.

On Wed, Aug 29, 2012 at 8:33 PM, Joshua Roesslein
notifications@github.comwrote:

Actually the build does fail, but the error isn't trivial to understand
(file not found).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2848#issuecomment-8136113.

[billdawson]

Okay, I've pushed some changes. Ready for re-review / testing.

On Wed, Aug 29, 2012 at 8:37 PM, Bill Dawson bill@billdawson.com wrote:

Agreed, I'm going to make that change pronto.

On Wed, Aug 29, 2012 at 8:33 PM, Joshua Roesslein <
notifications@github.com> wrote:

Actually the build does fail, but the error isn't trivial to understand
(file not found).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2848#issuecomment-8136113.

[joshthecoder]

Functional tested and code reviewed. Accepted