[TIMOB-10584] Android: WebView click event is not being fired #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add comments to the code to clarify why we do this change, update the doc and file a parity ticket for iOS. |
…more comments to change
|
I filed this ticket for IOS parity: https://jira.appcelerator.org/browse/TIMOB-10734 |
|
Here's the ticket filed for doc issues: https://jira.appcelerator.org/browse/TIDOC-777 |
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Sep 1, 2012
[TIMOB-10584] Android: WebView click event is not being fired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the call to super.onTouchEvent() gets made regardless of whether the event needs to cause a click to get fired. Both things must happen each time this method is called in order for events not to be dropped.