Timob 9999: Clean up Android platform code #2876
Conversation
|
Will CR + FR |
| @@ -207,17 +206,6 @@ protected void doSetBackgroundImage(Object image) | |||
| } | |||
| } | |||
|
|
|||
| @Kroll.setProperty(runOnUiThread=true) @Kroll.method(runOnUiThread=true) | |||
| public void setOrientation(int tiOrientationMode) | |||
There was a problem hiding this comment.
If we remove this property, the docs need to be updated accordingly as well. The state in the docs should be changed from 'deprecated' to 'removed'
|
Code reviewed. Before continuing with this PR, please test this against modules i.e. create a new module with this and run older modules with this change. This should be added as a part of the test instructions as well. I also mentioned that the docs need to be updated to the 'removed' state for APIs that transition from 'deprecated' to 'removed'. |
|
Code updated. Also ran ti.cloud + create new module and run it against PR. Ready for re-review. |
|
Code reviewed and functionally tested. Ran anvil, built the sdk, and tested modules. Request Accepted. |
Timob 9999: Clean up Android platform code
This PR removes dead code and deprecated code prior to 1.8.0.
Testing steps in JIRA: https://jira.appcelerator.org/browse/TIMOB-9999