Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-10707] iOS: Expose runtime errors to module developers #2881

Merged
merged 2 commits into from Sep 20, 2012
Merged

[TIMOB-10707] iOS: Expose runtime errors to module developers #2881

merged 2 commits into from Sep 20, 2012

Conversation

mstepanov
Copy link
Contributor

TIMOB-10707

FT instructions:
Use default KS app with the variations below:

  1. add Ti.include("nonexisting.js"); to the top of the app.'s
  2. Change win.open(); to win.openX();
  3. Add var a = new Array(0x100000000);
  4. See test instructions in JIRA comments
  5. With Xcode, modify TiWindowProxy.m -(void)windowDidOpen to add [self performSelector:@selector(nonexisting)];

In cases 1-3 a default red screen with error message and line information should appear.
In case 5, see a stack trace in console

@WhichKatieDid
Copy link
Contributor

CR passed.

@WhichKatieDid
Copy link
Contributor

Cases 1-3, when library was added, displayed a dialog with "Damn It!" and the OK button. Is this expected verbiage? In case 5, I could not tell the difference with and without the library. What should I be looking for?

@mstepanov
Copy link
Contributor Author

@BlainHamon with ti.pinkerror module included, "Damn It" dialog is expected. W/o the module, default red screen is expected. In case 5 should be no difference as ti.pinkerror module calls default handler (see it's sources)

@WhichKatieDid
Copy link
Contributor

Fair enough. Merging.

WhichKatieDid added a commit that referenced this pull request Sep 20, 2012
[TIMOB-10707] iOS: Expose runtime errors to module developers
@WhichKatieDid WhichKatieDid merged commit 33b6118 into tidev:master Sep 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants