Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 10289: Android: Unlike iOS, clicking on map outside the annotation does not deselect the annotation #2885

Merged
merged 7 commits into from Sep 13, 2012

Conversation

pingwang2011
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-10289
In this fix, a new property "enableZoomControls" is added to MapView. When this property is set to false, the built-in zoom controls are invisible and the annotation is deselected by clicking in the map view outside of the annotation.
Test steps in JIRA. Please also run KS -> Base UI-> View -> Map View for a sanity check.

…he built-in zoom controls are disabled, annotation can be deselected by clicking in the map view outside of the annotation.
@rusticphilosopher
Copy link
Contributor

A offline conversation should be had to discuss this further. Fallout from the Architecture meeting throws into doubt whether this change should be made at all.

@rusticphilosopher
Copy link
Contributor

Spoke with Ping and the plan is to allow annotation auto hide behavior and zoom control independently via two different flags. Care will be taken to ensure decoupling of annotation behavior form zoom controls so that implementation of TIMOB-9132 does not run into trouble based on this change.

Will wait for PR to be updated and then review.

@pingwang2011
Copy link
Contributor Author

Updated. Now the property "hideAnnotationWhenTouchMap" allows hiding the annotation by clicking elsewhere in the map view. This fix doesn't depend on zoom controls and doesn't change the current behavior of the built-in zoom controls.
Ready for review.

@rusticphilosopher
Copy link
Contributor

Reviewed and feedback left

@pingwang2011
Copy link
Contributor Author

Updated. Ready for review.

@rusticphilosopher
Copy link
Contributor

Code reviewed and FR passed on V8 and Rhino. ** Accepted **

rusticphilosopher pushed a commit that referenced this pull request Sep 13, 2012
Timob 10289: Android: Unlike iOS, clicking on map outside the annotation does not deselect the annotation
@rusticphilosopher rusticphilosopher merged commit dc7fe59 into tidev:master Sep 13, 2012
@yozef
Copy link

yozef commented Aug 20, 2015

@DizzyMonkey I've been using this feature on an Android Edge S6, and the lag between showing the infoWindow (Bubble of the Annotation) takes 'a good 6 seconds' for it to go away, after tapping anywhere else on the map outside the annotation. The thing is, the UI thread gets locked in some process, and it's repeatable. However, switching from annotation bubble to another annotation's bubble, it runs smoothly.

When map event's clicksource is null, which comes after a deselecting an Annotation bubble, the process takes 6 seconds to close, and locks the main UI thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants