New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 10289: Android: Unlike iOS, clicking on map outside the annotation does not deselect the annotation #2885
Conversation
…he built-in zoom controls are disabled, annotation can be deselected by clicking in the map view outside of the annotation.
…e into timob-10289
A offline conversation should be had to discuss this further. Fallout from the Architecture meeting throws into doubt whether this change should be made at all. |
Spoke with Ping and the plan is to allow annotation auto hide behavior and zoom control independently via two different flags. Care will be taken to ensure decoupling of annotation behavior form zoom controls so that implementation of TIMOB-9132 does not run into trouble based on this change. Will wait for PR to be updated and then review. |
…nnotation by clicking elsewhere in the map view.
…e into timob-10289
Updated. Now the property "hideAnnotationWhenTouchMap" allows hiding the annotation by clicking elsewhere in the map view. This fix doesn't depend on zoom controls and doesn't change the current behavior of the built-in zoom controls. |
Reviewed and feedback left |
Updated. Ready for review. |
Code reviewed and FR passed on V8 and Rhino. ** Accepted ** |
Timob 10289: Android: Unlike iOS, clicking on map outside the annotation does not deselect the annotation
@DizzyMonkey I've been using this feature on an Android Edge S6, and the lag between showing the infoWindow (Bubble of the Annotation) takes 'a good 6 seconds' for it to go away, after tapping anywhere else on the map outside the annotation. The thing is, the UI thread gets locked in some process, and it's repeatable. However, switching from annotation bubble to another annotation's bubble, it runs smoothly. When map event's clicksource is null, which comes after a deselecting an Annotation bubble, the process takes 6 seconds to close, and locks the main UI thread. |
https://jira.appcelerator.org/browse/TIMOB-10289
In this fix, a new property "enableZoomControls" is added to MapView. When this property is set to false, the built-in zoom controls are invisible and the annotation is deselected by clicking in the map view outside of the annotation.
Test steps in JIRA. Please also run KS -> Base UI-> View -> Map View for a sanity check.