New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 10698 Additional Anvil enhancements #2894
Conversation
…tering at the hub and various other enhancements
…luded in SDK. changed driver to use pulled down tests in remote mode rather than local tests
@@ -16,7 +16,11 @@ that make up a anvil test pass | |||
|
|||
|
|||
HUB: | |||
To be defined once the hub implementation is finished. | |||
The hub is a collection of various software components that live in a hosted linux environment and | |||
whos purpose is to serve as a bridge between driver instances and the CI server. An additional role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whose
Code review complete, just a very few minor things. Because some things were changed or moved around that could also affect local mode, I ran local mode tests for all three platforms. Nothing unexpected occurred. |
as we discussed this diff -- -- got the android browser working fine for me wrt mobileweb testing |
platform = "android", | ||
|
||
// if running for iOS, specify the version of Xcode | ||
xcodeVersion = "4.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax is incorrect. Should use ":" instead of "=".
Code reviewed. One comment is left. |
…x for browser when running for mobile web
Changes for timob-10823 (windows support) rolled into this PR for convenience sake as well as multiple changes based on PR feedback. |
CR accepted. FR fails for mobileweb due to http://pastie.org/4710069 (OSX and Windows). Note that Windows testing was successful for Android. :) So we're almost finished. @pingwang2011 needs to re-review as well. Though I think one of us -- me -- on Windows is enough. @pingwang2011 should just re-test OSX and redo the code review. Note that this PR is no longer merge-able. |
CR Accepted. |
Ready for review |
…n launch of url when running pass on Mobile Web
CR re-do accepted. FR on Windows accepted. @pingwang2011 if FR on OSX passes, you can merge. w00t! |
CR Accepted. FR on OSX passed. Request Accepted. |
Timob 10698 Additional Anvil enhancements
https://jira.appcelerator.org/browse/TIMOB-10698
Anvil changes include:
Once code review is done, functional test will basically require full deployment to hub server and all driver machines. Once CR is done, FR will require a quick meeting to lay out exactly what needs to be done and likely paired effort.