Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 10698 Additional Anvil enhancements #2894

Merged
merged 11 commits into from Sep 13, 2012
Merged

Timob 10698 Additional Anvil enhancements #2894

merged 11 commits into from Sep 13, 2012

Conversation

rusticphilosopher
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-10698

Anvil changes include:

  • rework remote mode to use pre built SDK from CI server rather than pulling from github
  • update and clarification to config files and readme
  • performance enhancements to php reporting on large reports
  • change to remote mode to utilize remote tests rather than local tests
  • inclusion of Anvil tests in built SDK
  • various smaller enhancements and tweaks

Once code review is done, functional test will basically require full deployment to hub server and all driver machines. Once CR is done, FR will require a quick meeting to lay out exactly what needs to be done and likely paired effort.

@@ -16,7 +16,11 @@ that make up a anvil test pass


HUB:
To be defined once the hub implementation is finished.
The hub is a collection of various software components that live in a hosted linux environment and
whos purpose is to serve as a bridge between driver instances and the CI server. An additional role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whose

@billdawson
Copy link
Contributor

Code review complete, just a very few minor things.

Because some things were changed or moved around that could also affect local mode, I ran local mode tests for all three platforms. Nothing unexpected occurred.

@billdawson
Copy link
Contributor

as we discussed this diff --

http://pastie.org/4702268

-- got the android browser working fine for me wrt mobileweb testing

platform = "android",

// if running for iOS, specify the version of Xcode
xcodeVersion = "4.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax is incorrect. Should use ":" instead of "=".

@pingwang2011
Copy link
Contributor

Code reviewed. One comment is left.
Ran Anvil in local mode on the three platforms. All work fine.

@rusticphilosopher
Copy link
Contributor Author

Changes for timob-10823 (windows support) rolled into this PR for convenience sake as well as multiple changes based on PR feedback.

@billdawson
Copy link
Contributor

CR accepted. FR fails for mobileweb due to http://pastie.org/4710069 (OSX and Windows).

Note that Windows testing was successful for Android. :) So we're almost finished. @pingwang2011 needs to re-review as well. Though I think one of us -- me -- on Windows is enough. @pingwang2011 should just re-test OSX and redo the code review.

Note that this PR is no longer merge-able.

@pingwang2011
Copy link
Contributor

CR Accepted.
Ran Anvil in local mode on OSX. Android and iOS passed. Mobileweb failed due to the same reason Bill described above.

@rusticphilosopher
Copy link
Contributor Author

Ready for review

…n launch of url when running pass on Mobile Web
@billdawson
Copy link
Contributor

CR re-do accepted. FR on Windows accepted. @pingwang2011 if FR on OSX passes, you can merge. w00t!

@pingwang2011
Copy link
Contributor

CR Accepted. FR on OSX passed. Request Accepted.

pingwang2011 added a commit that referenced this pull request Sep 13, 2012
Timob 10698 Additional Anvil enhancements
@pingwang2011 pingwang2011 merged commit 831ed4a into tidev:master Sep 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants