New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-10831]iOS 6: Fixing logging for device builds #2930
Conversation
|
||
size = sizeof(info); | ||
junk = sysctl(mib, sizeof(mib) / sizeof(*mib), &info, &size, NULL, 0); | ||
assert(junk == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really dont like assert. Just return 0 so it falls to the NSLog loop.
Updated. Checked on Xcode 4.5 for iOS6 device and Xcode 4.4 for iOS 5.1. Ready for re-review |
Code Reviewed. ACCEPTED |
FR failed. Xcode 4.5 + ios6 device does not print logs to console. |
Code Reviewed. ACCEPTED |
FR Passed. Tested the following configs. ACCEPTED |
[TIMOB-10831]iOS 6: Fixing logging for device builds
Test Case in JIRA
***Simple Test Case.
Make any app with api log and build it for diff conf (device/sim/release..)