Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-10733] iOS: transport.py/Xcode project settings - set minimum iOS SDK version #2972

Merged
merged 2 commits into from Sep 21, 2012
Merged

Conversation

mstepanov
Copy link
Contributor

TIMOB-10733

Test instructions are in JIRA

@WhichKatieDid
Copy link
Contributor

Question: Projector invocations are updated in all but one spot: projector.py, line 218. Is this okay, or should that be updated as well?
Other than that, CR accepted.

@WhichKatieDid
Copy link
Contributor

@mstepanov Please address question.

@mstepanov
Copy link
Contributor Author

@BlainHamon that one was never called, because it's a test case. Anyway, updated.

@WhichKatieDid
Copy link
Contributor

CR passed, doing FR.

@WhichKatieDid
Copy link
Contributor

FR failed. Building for device on iOS 6.0 caused the following log:

[INFO] One moment, building ...
[TRACE] app property, acs-oauth-secret-production : TknZAkIPx28t7dqZ2NUPyGCDivY8sxqJ
[TRACE] app property, acs-oauth-key-production : 2YbJydzD9vSiC33T4RqkCfWYknWaNDqO
[TRACE] app property, acs-api-key-production : ECvrzCCN3octYUqbRXFpJfWQONZulCxP
[TRACE] app property, acs-oauth-secret-development : nGREt8EUkf8jtfsO6nR27mkJtmnP7xnv
[TRACE] app property, acs-oauth-key-development : 7vSA7wHh8Y0CfeE9zr84MBHB2O6ylALo
[TRACE] app property, acs-api-key-development : eQdl7YnGbEPU4O7Q2ODcDvxIxVCeYU3m
[TRACE] app property, ti.ui.defaultunit : system
[DEBUG] Detecting modules in /Users/bhamon/Documents/Titanium_Studio_Workspace/TIMOB4410/modules
[DEBUG] Detecting modules in /Users/bhamon/Library/Application Support/Titanium/modules
[DEBUG] Detected module for android: ti.push 2.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/android/ti.push/2.0
[DEBUG] Detected module for android: ti.cloudpush 2.0.7 @ /Users/bhamon/Library/Application Support/Titanium/modules/android/ti.cloudpush/2.0.7
[DEBUG] Detected module for android: ti.cloudpush 2.0.5 @ /Users/bhamon/Library/Application Support/Titanium/modules/android/ti.cloudpush/2.0.5
[DEBUG] Detected module for android: ti.cloudpush 2.0.3 @ /Users/bhamon/Library/Application Support/Titanium/modules/android/ti.cloudpush/2.0.3
[DEBUG] Detected module for android: ti.cloudpush 2.0.1 @ /Users/bhamon/Library/Application Support/Titanium/modules/android/ti.cloudpush/2.0.1
[DEBUG] Detected module for android: ti.cloudpush 2.0.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/android/ti.cloudpush/2.0.0
[DEBUG] Detected module for commonjs: ti.cloud 2.3.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.3.0
[DEBUG] Detected module for commonjs: ti.cloud 2.2.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.2.0
[DEBUG] Detected module for commonjs: ti.cloud 2.1.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.1.0
[DEBUG] Detected module for commonjs: ti.cloud 2.0.5 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.0.5
[DEBUG] Detected module for commonjs: ti.cloud 2.0.4 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.0.4
[DEBUG] Detected module for commonjs: ti.cloud 2.0.1 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.0.1
[DEBUG] Detected module for commonjs: ti.cloud 2.0.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.0.0
[DEBUG] Detected module for commonjs: ti.cloud 2.0 @ /Users/bhamon/Library/Application Support/Titanium/modules/commonjs/ti.cloud/2.0
[DEBUG] Looking for Titanium Module id: ti.cloud, version: 2.0.4, platform: commonjs
[INFO] Titanium SDK version: 3.0.0 (09/20/12 17:33 c591e43)
[INFO] iPhone Device family: universal
[INFO] iPhone SDK version: 6.0
[INFO] Performing full rebuild. This will take a little bit. Hold tight...
...
[DEBUG] Looking for Titanium Module id: ti.cloud, version: 2.0.4, platform: commonjs
[INFO] Minimum iOS version: 4.0
[INFO] Performing clean build
[INFO] Installing application in iTunes ... one moment
[DEBUG] executing command: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin/PackageApplication /Users/bhamon/Documents/Titanium_Studio_Workspace/TIMOB4410/build/iphone/build/Debug-iphoneos/TIMOB4410.app
[INFO] iTunes sync initiated

App was built with v7 only, but xcodeproj and the like still used 4.0 as the minimum.

@mstepanov
Copy link
Contributor Author

@BlainHamon building with Xcode 4.5 results with armv7 only. Not a fault of this PR.

@WhichKatieDid
Copy link
Contributor

The xcodeproj still says armv6, and we don't build for armv7s, but it's still a step forward. Merging.

WhichKatieDid added a commit that referenced this pull request Sep 21, 2012
[TIMOB-10733] iOS: transport.py/Xcode project settings - set minimum iOS SDK version
@WhichKatieDid WhichKatieDid merged commit 004bfec into tidev:master Sep 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants