Timob 10772 CLI project command #2977
Conversation
| }; | ||
|
|
||
| exports.run = function (logger, config, cli) { | ||
| }; | ||
| debugger; |
There was a problem hiding this comment.
Debugger statement left in.
|
We should support "ios" and "ipad". Even though "ipad" is not a "platform", it is an explicit option. "ios" would simply make both ipad and iphone true. It would be nice if we ignored certain files (.gitignore, .DS_Store, etc) and directories (.git) when copying files. |
| if (value[p]) { | ||
| templateDir = path.join(sdkPath, value[p], 'templates', 'app', cli.argv.template); | ||
| if (!appc.fs.exists(templateDir)) { | ||
| logger.error(__('Template ') + cli.argv.template + __(' is not supported by platform ') + value[p]); |
There was a problem hiding this comment.
This should be:
logger.error(__('Template %s is not supported by platform %s', cli.argv.template, value[p]) + '\n');
|
The project command is completely platform agnostic. It queries the SDK to see what platforms are available and validates against those. Is there any way we can tie into that for the ipad part? I would prefer not to hard code these things if at all possible. I think that we should probably ignore all hidden files if we are going to ignore anything. Thoughts? |
|
Code reviewed and tested. Request APPROVED. |
Timob 10772 CLI project command
No description provided.