timob-10993: Fix crashing issue when targetSdkVersion is 11+ #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -679,6 +680,14 @@ public boolean dispatchKeyEvent(KeyEvent event) | |||
| @Override | |||
| public boolean onCreateOptionsMenu(Menu menu) | |||
| { | |||
| // If targetSdkVersion is set to 11+, Android will invoke this function | |||
| // to initialize the menu (since it's part of the action bar). Due | |||
| // to the fix for bug 2373, activityProxy won't be initialized b/c the | |||
There was a problem hiding this comment.
We probably want to refer to this as 'android bug 2373' to make it clear
|
Testing instructions need to be updated to use create an apk, upload to the phone, and then install with astro (or some file system app). This is the only way to trigger the restart dialog for android bug 2373. |
|
Code updated. Ready for re-review. |
|
The test cased mentioned in the Jira failed. I had to modify the test instructions to get it working correctly. |
|
I've updated the test instructions in Jira. Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Sep 29, 2012
timob-10993: Fix crashing issue when targetSdkVersion is 11+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA: https://jira.appcelerator.org/browse/TIMOB-10993