TIMOB-4570 fix a mistake inside the drillbit test itself. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -520,27 +520,28 @@ describe("Ti.XML tests", { | |||
| apiXmlDocumentImportNode: function() { | |||
| var doc = Ti.XML.parseString("<a/>"); | |||
| var otherDoc = Ti.XML.parseString(this.testSource["with_ns.xml"]); | |||
| var cakeNode = otherDoc.documentElement.getElementsByTagNameNS("http://example.com", "cake").item(0); | |||
There was a problem hiding this comment.
should we assert the length of the node list here? (assert non-null on cakeNode too?)
|
Code review accepted |
|
Code reviewed. Tested with Drillbit. Request Accepted. |
donthorp
added a commit
that referenced
this pull request
Jul 29, 2011
TIMOB-4570 fix a mistake inside the drillbit test itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-4570?focusedCommentId=160913&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-160913
I made a mistake in the
apiXmlDocumentImportNode, forgetting that child nodes can also be text. This fixes the test.The result should be that all
apiXmlDocument*tests should succeed.