Timob 6715: iOS: validatesSecureCertificate parity #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -109,7 +109,11 @@ -(id)init | |||
| { | |||
| readyState = NetworkClientStateUnsent; | |||
| autoRedirect = [[NSNumber alloc] initWithBool:YES]; | |||
| validatesSecureCertificate = [[NSNumber alloc] initWithBool:NO]; | |||
| #if DEBUG | |||
There was a problem hiding this comment.
#if defined(DEBUG) || defined(DEVELOPER). Also as per styling guidelines this must not be indented
|
Code reviewed. Minor points. Otherwise looks ok |
|
Code updated. |
|
Code Reviewed. ACCEPTED |
|
Docgen and validate passed. Correctly set to false on debug builds. Unable to verify release build but should work. ACCEPTED |
vishalduggal
added a commit
that referenced
this pull request
Oct 2, 2012
Timob 6715: iOS: validatesSecureCertificate parity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA: http://jira.appcelerator.org/browse/TIMOB-6715