Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-11026] Fix builder.py for min version support #3066

Merged
merged 1 commit into from Sep 27, 2012
Merged

[TIMOB-11026] Fix builder.py for min version support #3066

merged 1 commit into from Sep 27, 2012

Conversation

vishalduggal
Copy link
Contributor

QE should do FR
TICKET

@eric34
Copy link
Contributor

eric34 commented Sep 27, 2012

Pull accepted:
Verified setting min iOS below 4.0:
[INFO] Minimum iOS version 3.2 is lower than 4.0: Using 4.3 as minimum
Verified build with iOS 6 will install on 4.3+ and not on 4.0.2 device

Verified setting to iOS 9.9 will set to min 6.0
[INFO] Minimum iOS version 9.9 is greater than 6.0 (iphone_version): Using 6.0 as minimum
Verified this build will install only on iOS 6 (not 4.0.2, 4.3.3, or 5.1)

Verified bogus setting "jeff cool cold game" for min setting defaults to 4.3 (Xcode 4.5)
[WARN] Could not parse value jeff cool coldgame as 'x.x' version: Setting to default
[INFO] Minimum iOS version 0.0 is lower than 4.0: Using 4.3 as minimum

Verified setting to 5.0 and got expected results

Repeated above with Xcode 4.4.1 (Min iOS) and included packaging both with ad-hoc and app store distribution

srahim added a commit that referenced this pull request Sep 27, 2012
[TIMOB-11026] Fix builder.py for min version support
@srahim srahim merged commit 1193605 into tidev:master Sep 27, 2012
@vishalduggal vishalduggal deleted the timob-11026 branch October 27, 2014 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants