TIMOB-11121: CLI: Create wrapper around existing android builder.py #3085
Conversation
ghost
assigned 
| logger.info(__('Compiling "%s" build', cli.argv['deploy-type'])); | ||
|
|
||
|
|
||
| ti.legacy.constructLegacyCommand(logger, cli, tiapp,cli.argv.platform ,cmd, emulatorCmd); |
There was a problem hiding this comment.
spaces around commas are inconsistent
|
If any of the python scripts crash currently, that crash goes undetected and the build process continues on. A crash should be detected (return code probably) and the build should fail then and there. |
|
|
||
| dump(cli.argv); | ||
| console.log('Forking correct SDK command: ' + (cmd.join(' ')).cyan + '\n'); |
There was a problem hiding this comment.
Should this log be removed?
There was a problem hiding this comment.
I would say leave it, but comment it out.
|
When building for the playstore, if the output directory doesn't exist, it should be automatically created |
|
If android build fails, we should not print that build was successful |
|
Paths should be converted to absolute using path.resolve (specifically --output-dir) |
|
Need to add logic for the -b (build only) flag |
|
Regarding the paths should be converted to absolute paths, use appc.fs.resolvePath(), not path.resolve(). path.resolve() does not resolve paths that start with "~". |
|
I've changed up how a build reports if it was successful or not. If the Android build fails, simply call the finished() callback with anything truthy (i.e. the "err"). The message will print correctly once my I do a PR for my stuff. |
- Resolve paths correctly - Check exit code on spawn process and error accordingly - Commented out debugging code - Support build-only option
|
Code updated. Ready for review again. |
…n-zero return code.
|
Code reviewed and tested. Request accepted |
TIMOB-11121: CLI: Create wrapper around existing android builder.py
http://jira.appcelerator.org/browse/TIMOB-11121