Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-13301] Add animation to scrollToView, moveNext, movePrevious on ScrollableView #3146

Closed
wants to merge 4 commits into from

Conversation

farfromrefug
Copy link
Contributor

jira-ticket

  • added moveNext and movePrevious on ios
  • setCurrentPage is now NOT animated to follow ios behavior (and documented)
  • added optional argument to moveNext, movePrevious and scrollToView. It s a boolean for animated
  • fix an out of bound error on android

YET TO DO

I am having 2 issues on the android version for which i need help

  • for the option boolean argument of moveNext, movePrevious and scrollToView. The default value is set to false, how can i set it to true? couldnt find it
  • The doc says that removeView and scrollToView should accept an integer or a view. I couldnt find how to setup the kroll method on android to do so. I already prepared the backend. i only need to update the kroll methods.

thanks

now moveNext, movePrevious, scrollToView can take an optional argument "animated". It should be true by default. Right now it s false on android. Have to find a work around
changed the behaviour of setcurrentpage on android. Now it s not animated for consistency with iOS
@farfromrefug
Copy link
Contributor Author

I solved everything. I also updated the test case on jira.
One question though

let s say you are on view 2.
You remove view 1.
The scrollview automatically switches to view 3!
Is that the expected behavior. I find it pretty strange.
Also if it did not you could easily code an infinite scrollview

@ingo
Copy link
Contributor

ingo commented Feb 21, 2014

We will be investigating this for 3.3.0. However, we are likely to adopt a slightly different API as noted in the linked ticket where we don't need the boolean for animate. If you are interested in updating your PR, that would be helpful.

@farfromrefug
Copy link
Contributor Author

Once again be very careful. Very old code, can't support it anymore

@skypanther
Copy link
Contributor

This seems to have been resolved through a separate PR as noted on https://jira.appcelerator.org/browse/TIMOB-13301. Closing this PR. Please reopen if I misread the history and this is still a valid request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants