timob-11339: fix the source of tabGroup focus events. #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
|
||
| String event = focused ? TiC.EVENT_FOCUS : TiC.EVENT_BLUR; | ||
|
|
||
| if (eventEmitter instanceof TabProxy) { |
There was a problem hiding this comment.
We can probably factor out line 209 and just do something like:
if (win != null ) {
// fire for window
} else {
// fire for tab
}
|
Code updated. |
| // The window is optional and will be skipped if it does not exist. | ||
| String event = focused ? TiC.EVENT_FOCUS : TiC.EVENT_BLUR; | ||
|
|
||
| if (window == null) { |
There was a problem hiding this comment.
Actually since we fire the event onto the tab in either condition (window is present for this tab or not) we can get rid of the else.
if (window != null) {
// fire event onto window first.
}
// fire event onto tab
Sorry about going around in circles. Didn't notice the fireEvent for tab was the same in both conditions. :\
|
Code reviewed. Accepted |
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Oct 12, 2012
timob-11339: fix the source of tabGroup focus events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA: http://jira.appcelerator.org/browse/TIMOB-11339