[TIMOB-11340] Android: Can't add menu items to ActionBar-style tab group #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each tab window should have their activity set to that of the tab group. So if you access `window.activity` you should get the proxy for the activity hosting the tab group. [TIMOB-11340]
|
Please merge against master. Some of the functionalities has been changed to fix other regressions |
Conflicts: android/modules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUIAbstractTab.java
|
Merged with master. |
|
Code reviewed and functionally tested. Request accepted. |
hieupham007
added a commit
that referenced
this pull request
Oct 13, 2012
[TIMOB-11340] Android: Can't add menu items to ActionBar-style tab group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken
window.activityproperty for tab windows.With this fix each property should now reference the activity
hosting the tab group.
See JIRA ticket for test case.