[TIMOB-10891] Tabgroup leaks memory #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into timob-10891
…e into timob-10891
ghost
assigned 
| @@ -30,7 +29,7 @@ -(id)initWithProxy:(TiWindowProxy*)window_ tab:(TiUITabProxy*)tab_ | |||
| { | |||
| if (self = [self initWithViewProxy:window_]) | |||
| { | |||
| tab = [tab_ retain]; | |||
| tab = tab_; | |||
There was a problem hiding this comment.
please add a comment to .h file that tab is now assign(non-retain) ivar.
|
Added comments to header files. Ready for review. |
| [self closeWindow:[current window] animated:YES removeTab:YES]; | ||
| [controller setDelegate:nil]; | ||
| if ([[controller viewControllers] count] > 1) { | ||
| NSMutableArray* doomedVcs = [[NSMutableArray arrayWithArray:[controller viewControllers]] retain]; |
There was a problem hiding this comment.
Not critical, but the returned array is already autoreleased, so no retain/release is required for doomedVcs
There was a problem hiding this comment.
Specifically retained it in case the autorelease pool gets drained due to GC which might be problematic.
|
Code reviewed. Tentatively approved |
|
FT: crash with TIMOB-7152 |
|
Core reviewed. APPROVED |
|
FT PASSED |
mstepanov
pushed a commit
that referenced
this pull request
Oct 17, 2012
[TIMOB-10891] Tabgroup leaks memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in JIRA
Be sure to test code in comments
Regress against
TIMOB-7858
TIMOB-7714
TIMOB-7644
TIMOB-7152
TIMOB-7791
TIMOB-7820
KS smoke test