TIMOB-11273: Android: KS Web Views > Local URL: Apple logo and html text not appearing. #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag, and re-inject the binding code when we refresh
ghost
assigned 
| StringBuilder sb = new StringBuilder(html.length() + 2500); | ||
| sb.append(html.substring(0, tagEnd + 1)); | ||
| sb.append(TiWebViewBinding.SCRIPT_TAG_INJECTION_CODE); | ||
| sb.append(html.substring(tagEnd + 1)); |
There was a problem hiding this comment.
Should check if(tagEng+1 < html.length()) before calling substring().
|
Code reviewed. Please address comment. |
|
Code reviewed and functionally tested. In the test case in TIMOB-10397, clicking log message after loading a remote webview displays the hello message, which should not happen. |
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Oct 15, 2012
TIMOB-11273: Android: KS Web Views > Local URL: Apple logo and html text not appearing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-11273
Test case in Jira.
Please also run the test case in http://jira.appcelerator.org/browse/TIMOB-10397.