Timob 11264: Fix 'android:back' for tabgroup #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@joshthecoder may have a better approach for this ticket, so I'm going to hold off on reviewing. |
| @@ -56,6 +56,7 @@ public View getContentView() { | |||
| Activity tabGroupActivity = ((TabProxy) proxy).getTabGroup().getActivity(); | |||
| contentView.setActivity(tabGroupActivity); | |||
|
|
|||
| contentView.getKrollObject().setProxySupport(contentView); | |||
There was a problem hiding this comment.
We should leave a comment here on what we're doing here, like all other setup stuff we do in this method.
|
Code reviewed, left several comments. |
| if (event.getAction() == KeyEvent.ACTION_UP) { | ||
| window.fireEvent("android:back", null); | ||
| window.fireEvent(backEvent, null); |
There was a problem hiding this comment.
We should fire the event only onto the activity. Then forward listeners on the window to the activity proxy in window.js.
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Oct 18, 2012
Timob 11264: Fix 'android:back' for tabgroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing steps in JIRA: http://jira.appcelerator.org/browse/TIMOB-11264