Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-11463 Android: Fix accessibility properties on old-style table rows. #3242

Merged
merged 1 commit into from Oct 17, 2012
Merged

TIMOB-11463 Android: Fix accessibility properties on old-style table rows. #3242

merged 1 commit into from Oct 17, 2012

Conversation

billdawson
Copy link
Contributor

Fail case in JIRA

@ghost ghost assigned ayeung Oct 16, 2012
@ayeung
Copy link
Contributor

ayeung commented Oct 17, 2012

Code reviewed and functionally tested. For the 'accessibilityHidden' test case, the row can't be selected, but I need to verify whether that is the expected behavior. Will merge once I confirm with Bill.

@billdawson
Copy link
Contributor Author

That's expected. Imagine you're blind and your finger is moving across the
screen. If one of the controls is "hidden" from you, it means you cannot
"feel" it, so to speak. You get no feedback from it as you go over it,
because it's hidden from you.

On Wednesday, October 17, 2012, ayeung wrote:

Code reviewed and functionally tested. For the 'accessibilityHidden' test
case, the row can't be selected, but I need to verify whether that is the
expected behavior. Will merge once I confirm with Bill.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3242#issuecomment-9511897.

@ayeung
Copy link
Contributor

ayeung commented Oct 17, 2012

Sounds good. Merging.

ayeung pushed a commit that referenced this pull request Oct 17, 2012
TIMOB-11463 Android: Fix accessibility properties on old-style table rows.
@ayeung ayeung merged commit 8a41c82 into tidev:master Oct 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants