New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-11510] reproxy subviews of tableview rows when className specified #3260
Conversation
@BlainHamon ready for CR+FR |
__block BOOL result = YES; | ||
if (deep) { | ||
NSArray *subProxies = [newProxy children]; | ||
NSArray *oldSubProxies = [oldProxy children]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self. We really should consider a childrenCount property to shortcut the copying that would be done here if the counts differ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlainHamon these used not only for counts, but actual iterations too.
CR tentative. I really don't feel comfortable with the area around the line note, given how expensive children can be. |
FR inconclusive. Couldn't tell speed difference, although it looks like no objects are accruing or leaking. |
Retesting with iPad 1. |
Still can't tell the difference. Added to that, the sample code provided keeps reporting [WARN] Hex color passed looks invalid: with a blank string. Do suggest adding a childrenCount accessor to TiViewProxy, using that where possible, to avoid using the expensive children accessor unless actually needed. Needs addressing. |
[TIMOB-11510] reproxy subviews of tableview rows when className specified
TIMOB-11510
Test instructions:
Test another example in JIRA comments. Ensure ERROR messages printed to console.
Test for regressions with TIMOB-9500 and TIMOB-5429