Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-11510] reproxy subviews of tableview rows when className specified #3260

Merged
merged 3 commits into from Oct 30, 2012
Merged

[TIMOB-11510] reproxy subviews of tableview rows when className specified #3260

merged 3 commits into from Oct 30, 2012

Conversation

mstepanov
Copy link
Contributor

TIMOB-11510

Test instructions:

  1. use example project attached to the JIRA.
  2. ensure smooth scrolling performance comparing to before the fix.
  3. use Instruments/Core Animation to measure FPS during scrolling for comparison.
  4. use Instruments/Allocations to ensure number of allocated TiUILabel, UILabel, TiUITableViewRowContainer is not increasing as table scrolls.

Test another example in JIRA comments. Ensure ERROR messages printed to console.

Test for regressions with TIMOB-9500 and TIMOB-5429

@mstepanov
Copy link
Contributor Author

@BlainHamon ready for CR+FR

__block BOOL result = YES;
if (deep) {
NSArray *subProxies = [newProxy children];
NSArray *oldSubProxies = [oldProxy children];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self. We really should consider a childrenCount property to shortcut the copying that would be done here if the counts differ.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlainHamon these used not only for counts, but actual iterations too.

@WhichKatieDid
Copy link
Contributor

CR tentative. I really don't feel comfortable with the area around the line note, given how expensive children can be.

@WhichKatieDid
Copy link
Contributor

FR inconclusive. Couldn't tell speed difference, although it looks like no objects are accruing or leaking.

@WhichKatieDid
Copy link
Contributor

Retesting with iPad 1.

@WhichKatieDid
Copy link
Contributor

Still can't tell the difference. Added to that, the sample code provided keeps reporting [WARN] Hex color passed looks invalid: with a blank string. Do suggest adding a childrenCount accessor to TiViewProxy, using that where possible, to avoid using the expensive children accessor unless actually needed. Needs addressing.

WhichKatieDid added a commit that referenced this pull request Oct 30, 2012
[TIMOB-11510] reproxy subviews of tableview rows when className specified
@WhichKatieDid WhichKatieDid merged commit 86d2838 into tidev:master Oct 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants