Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-11941] relayout before showing view #3297

Closed
wants to merge 2 commits into from

Conversation

farfromrefug
Copy link
Contributor

jira ticket

First setHidden method was incorrectly checking if the view was currently hidden. In fact if you create a view with visible:false, then when showing the view, setHidden would not call willShow.

Now in willShow the relayout was enqueued. It should be done immediately to make sure the view has the correct layout right away.
I called refreshView but may be that s not the right call to make. It works but i was not sure of the "level" of refreshView.

in willShow we should relayout immediately and not queue the relayout
@ingo
Copy link
Contributor

ingo commented Feb 21, 2014

Thank you for the contribution. We currently believe that this approach may actually decrease performance so we are concerned with the particular implementation here, though we are planning on addressing this for 3.3.0. Any thoughts?

@farfromrefug
Copy link
Contributor Author

Well i actually completely rewrote the layout system because of refreshView. That method is a lot too expensive.
I went for a recursively up check of needed layout.
The idea is that in a view, if one child requires layout, it does mean you should relayout the whole parent and all its children.

So i guess this PR is simply dead ;)

@farfromrefug farfromrefug deleted the TC-1417 branch February 24, 2014 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants