[TC-1426] Better way of handling property change. Especially this will work with T... #3309
Conversation
…h Ti.UI.android.openPreferences()
ghost
assigned 
| public void onSharedPreferenceChanged(SharedPreferences prefs,String key) { | ||
| KrollDict result = new KrollDict(); | ||
| result.put("property", key); | ||
| fireEvent(TiC.EVENT_CHANGE, result); |
There was a problem hiding this comment.
Android and iOS did not have the "property" property associated with "change" event before. Why do you add this property here?
|
In the test case in JIRA, it does not call Ti.UI.Android.openPreferences(). But the in the ticket description, you said "Ti.App.Properties.addEventListener('change', onChange) should support Ti.UI.Android.openPreferences". Did you miss something in the test case to test this new feature? |
|
Yes i think i was too lazy at the time, and i didnt do an openPreferences nor produced a preferences.xml |
|
Hi farfromrefug, we are trying to clean up the PR queue. This PR is sitting here for a long time without any update. If you can not address the comments in this week, we will close it. |
...i.UI.android.openPreferences()
jira ticket