Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIDOC-857 Updated description of Notification.sound #3343

Merged
merged 2 commits into from Nov 1, 2012

Conversation

arthurevans
Copy link
Contributor

Described limitations and workaround from TIMOB-5239.

Described limitations and workaround from TIMOB-5239.
@ghost ghost assigned hieupham007 Oct 29, 2012
    var outPath = outFile.nativePath;
    if (! outFile.exists()) {
        var inFile = Ti.Filesystem.getFile(Ti.Filesystem.resourcesDirectory, resourceFilename);
        inFile.copy(outPath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an exception when running this code: .../sound/cricket.wav(No such file or directory) - I have circket.wav in /Resources dir.

@hieupham007
Copy link
Contributor

Code reviewed. Please address comments.

@arthurevans
Copy link
Contributor Author

OK, looks like we need to create the directory. Updated code sample.

@hieupham007
Copy link
Contributor

Code reviewed and functionally tested. Request accepted

@ghost ghost assigned bhatfield Nov 1, 2012
@arthurevans
Copy link
Contributor Author

Ben, can you do a DR and merge if it passes?

@bhatfield
Copy link
Contributor

DR accepted. Ran validate and deploy.

bhatfield pushed a commit that referenced this pull request Nov 1, 2012
TIDOC-857 Updated description of Notification.sound
@bhatfield bhatfield merged commit 05eaec8 into tidev:master Nov 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants