Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-13153] added Ti javascript property to get the current script relative path to resources #3377

Closed
wants to merge 2 commits into from

Conversation

farfromrefug
Copy link
Contributor

...Ressources.

I had to make a choice for the property name....
I am ok to change it if not appropriate

jira ticket

@ghost ghost assigned vishalduggal Nov 7, 2012
@farfromrefug
Copy link
Contributor Author

better late than never!
I hope this one is gonna make it soon, it s a small but useful one. First step to full native js module

@sindresorhus
Copy link

👍

@srahim srahim assigned pec1985 and unassigned vishalduggal Feb 21, 2014
@pec1985
Copy link
Contributor

pec1985 commented Apr 16, 2014

Code reviewed and tested.

Few comments:

  • The path, since it is supposed to be relative to the resources, needs to start with / and name all the folders to that file
  • Parity between iOS and Android, please test Ti.include as well as require
  • On Android the path is relative to the Resources while on iOS is relative to the file that required/included it.
  • On Android, if using require the file name is included in the path while in iOS only the folder names

Please address the comments and we'll move forward.

@pec1985
Copy link
Contributor

pec1985 commented Apr 28, 2014

Closing ticket, follow this PR #5650

@pec1985 pec1985 closed this Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants