Timob 11601: Android: Expose ActionBar methods #3387
Conversation
|
The documentation has a mistake, I think. The "logo" property isn't a background image for the bar, right? name: logo |
|
Yep, I think that should be something like 'Sets the application logo displayed in the "home" area of the action bar.' I think if we expose logo, we should expose icon as well--in some circumstances, Android replaces the logo with the icon (for example, if you go into the YouTube app and expand and collapse the search widget, you'll see the wide "YouTube" logo get replaced with the narrower YouTube icon. |
Exposed ability to set the icon on the action bar.
|
Good catch. I've updated the docs, and also added the ability to set the icon as well on the action bar. |
ghost
assigned 
|
Needs master merged into it and re-push. Functional review failed. Complete results: test case for 11642 fails: no log message for click event. test case for 11643 fails: Runtime error on startup: "Object # has no method 'setDisplayHomeAsUpEnabled". test case for 11644 succeeds. test case for 11645 succeeds. test case for 11646 succeeds. test case for 11648 succeeds. Will wait till further code changes (to address above) before CR'ing. |
| if (actionBarProxy != null) { | ||
| KrollFunction onHomeIconItemSelected = (KrollFunction) actionBarProxy | ||
| .getProperty(TiC.PROPERTY_ON_HOME_ICON_ITEM_SELECTED); | ||
| KrollDict event = new KrollDict(); |
There was a problem hiding this comment.
This and the next line: shouldn't they (can't they) be executed only if the actionBarProxy is not null? To save cycles.
|
CR/FR accepted. (One minor quibble in the CR, but it's not enough to hold this up.) If @arthurevans is okay with the docs, I'd like to merge asap so we can move on to the 3.0 backport which, if it tests out okay, should be merged today. |
|
BTW, validate.py and docgen.py were fine. |
|
Going to go ahead and merge, since we merged the 3.0.X equivalent. |
Timob 11601: Android: Expose ActionBar methods
http://jira.appcelerator.org/browse/TIMOB-11601
The test cases are in Jira. Please go through each subtask and run the test cases there.