[TIMOB-11728][TIMOB-11697] New properties for HTTPClient on iOS #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into timob-11728
| } | ||
|
|
||
| try | ||
| { |
There was a problem hiding this comment.
Try and catch blocks should have '{' on the same line according to our coding standards (You do this is in a couple of places here.)
|
Code reviewed. Please address comments. |
| @@ -0,0 +1,51 @@ | |||
| /** | |||
| * Appcelerator Titanium Mobile | |||
| * Copyright (c) 2010-2012 by Appcelerator, Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
Should technically be 2012 only =)
|
Code reviewed and functionally tested. Ran test case in Jira and KS. |
ayeung
pushed a commit
that referenced
this pull request
Dec 4, 2012
[TIMOB-11728][TIMOB-11697] New properties for HTTPClient on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes new properties to HTTPClient on iOS
clientCertificates
clientCertificateIdentity
IOS TICKET
For Android it allows creating a custom SSL Context with user defined trust managers and key managers.
ANDROID TICKET
Useful for environments with self signed certificates.
Doc PR will come later