Timob 11697: Added hooks to support SSL certificate store module #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public void setTrustManager(X509TrustManager manager) | ||
| { | ||
| trustManager = manager; |
There was a problem hiding this comment.
SSL Context is initialized with an array of trust managers and key Managers. So we should be maintaining corresponding arrays in our client.
|
Code updated. |
|
PR has merge conflicts. Have incorporated the changes from this PR into PR #3429. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-11697
Test case in Jira.
Note that I have not added documentation for these hooks since they are only used for native modules and we have plans to eventually move this into platform. I created a ticket for this here: http://jira.appcelerator.org/browse/TIDOC-899