Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-11866](dbl)click now fired on touchesEnded/UITouchPhaseEnded #3524

Merged
merged 1 commit into from Dec 6, 2012
Merged

[TIMOB-11866](dbl)click now fired on touchesEnded/UITouchPhaseEnded #3524

merged 1 commit into from Dec 6, 2012

Conversation

vishalduggal
Copy link
Contributor

For TIMOB-11866

Fixes a couple of issues.

  1. Now we have parity as to when click/dblclick fires between buttons and regular views (touchend).
  2. The Button kept firing the dblclick event repeatedly even when tapCount > 2 while regular views did not. Fixes that as well.

This of course means we do not track clicks past the second click on buttons (but that was incorrect anyways)

@srahim
Copy link
Contributor

srahim commented Dec 6, 2012

Code Reviewed and APPROVED

@srahim
Copy link
Contributor

srahim commented Dec 6, 2012

Functionally tested and APPROVED

srahim added a commit that referenced this pull request Dec 6, 2012
[TIMOB-11866](dbl)click now fired on touchesEnded/UITouchPhaseEnded
@srahim srahim merged commit 1066f7b into tidev:master Dec 6, 2012
@vishalduggal vishalduggal deleted the timob-11866 branch October 27, 2014 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants