Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-11971] Android: ImageView shows blank image for web content #3535

Merged
merged 4 commits into from Dec 19, 2012
Merged

[TIMOB-11971] Android: ImageView shows blank image for web content #3535

merged 4 commits into from Dec 19, 2012

Conversation

krowley
Copy link
Contributor

@krowley krowley commented Dec 5, 2012

@hieupham007
Copy link
Contributor

Im getting unknown host exception with the test case in Jira. Plus the fix doen't make sense based on the problem's description. Can you elaborate?

@krowley
Copy link
Contributor Author

krowley commented Dec 10, 2012

There are some cases where an AsyncTask does onPostExecute() but no image
is ready for display — for example, if the image has to be retrieved from the internet,
another background task is started, but onPostExecute() doesn't have any image.
The fix is to protect against that case.

@hieupham007
Copy link
Contributor

I've tested the new fix about 30 times on 2.x device, can still reproduce the bug.

@krowley
Copy link
Contributor Author

krowley commented Dec 13, 2012

Did it fail for all 30 attempts? I'm not able to find a device where this fails right now. Can I borrow yours?

hieupham007
hieupham007 reviewed Dec 19, 2012
View reviewed changes
android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiImageView.java
imageView.setImageResource(0);
}
else
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bracket should be on the same line as the "else"

@hieupham007
Copy link
Contributor

No, it seems that what I saw is a memory issue, not related to this ticket. Will file a separate JIRA for it. Code reviewed, please address comments.

@hieupham007
Copy link
Contributor

Code reviewed and functionally tested. Request accepted.

hieupham007 added a commit that referenced this pull request Dec 19, 2012
@hieupham007
Merge pull request #3535 from krowley/timob-11971
adb29db 
[TIMOB-11971] Android: ImageView shows blank image for web content
@hieupham007 hieupham007 merged commit adb29db into tidev:master Dec 19, 2012
@vishalduggal vishalduggal mentioned this pull request Jan 16, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krowley @hieupham007