[TIMOB-8708] Android: Loading a large list of contacts w/ photos is slow #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low -- The big win here is using JPEG format, specifying a quality of under 100 is marginal so I backed out that part of the change.
…low -- fix bad comment
…low -- remove unneeded change
|
The image quality in the code is 100, not 60, and I'm not seeing any performance increase when testing with 50+ contacts. |
ghost
assigned 
|
It seems like your test case may not be big enough to expose the problem. I can loan you my Nexus 7 with contacts -- on that device it's pretty apparent. |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Dec 14, 2012
[TIMOB-8708] Android: Loading a large list of contacts w/ photos is slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TIMOB-8708 for test case
The change here is to output the contacts image as a JPEG with a quality of 60.