TIMOB-11820: Android: ScrollableView in ScrollView is not working #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 6, 2012 17:31
…rollable on android Ti 2.1" This reverts commit 533f6d1.
… scroll view parent
ghost
assigned 
| public boolean dispatchTouchEvent(MotionEvent ev) | ||
| { | ||
| // If the parent is a scroll view, then we prevent the scroll view from intercepting touch events | ||
| if (this.getParent() instanceof TiScrollViewLayout) { |
There was a problem hiding this comment.
should probably just call getParent().
|
Code reviewed and functionally tested. Looks good, will merge after comment is addressed. |
|
Code updated. |
hieupham007
added a commit
that referenced
this pull request
Jan 31, 2013
TIMOB-11820: Android: ScrollableView in ScrollView is not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-11820
Please use the test case in the comments, but set the 'canCancelEvents' property in the scroll view to true. I have made changes to the scrollable view, so you do not need to set the 'canCancelEvents' on the scrollview.
Please also run the test case in https://jira.appcelerator.org/browse/TIMOB-9955. Since the user specified 'canCancelEvents' events to be false, the blue view SHOULD be unscrollable. I have documented that this may be different in iOS in the docs.