Timob 11912 Fixed maps not sizing correctly after a layout #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, but doesn't work. Try again. |
|
Zooming has been fixed. There is still an issue with the map "animating" in, but it's a bug in Google Maps as far as I can tell. The animation happens explicitly because of a call to the native GMaps method fitBounds, which according to the docs isn't supposed to animate. It sounds like they aren't removing a transition or something from the map. |
|
Code reviewed and tested. works as described above. Request accepted |
|
Sorry guys, but this is still broken in Chrome, Firefox, and most importantly Mobile Safari. In fact, it's actually worse in Mobile Safari. I don't why this was merged. This pull request has been reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.