TIMOB-4345 Android: focus and blur events don't fire on window with url #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has no url but is not lightweight
… NOT go into the current stable branch -- commit 1183a48 is enough to fix the problem in the ticket)
| @@ -140,11 +140,13 @@ public class TiUIWindow extends TiUIView | |||
|
|
|||
| protected void initContext() | |||
| { | |||
| boolean hasUrl = proxy.hasProperty(TiC.PROPERTY_URL); | |||
There was a problem hiding this comment.
Should this use the resolver to handle the case the URL was put in the open call?
…stead of just proxy.hasProperty since url could be passed in open() arguments.
| if (!newActivity) { | ||
| if (activity instanceof TiBaseActivity) { | ||
| activityProxy = ((TiBaseActivity)activity).getActivityProxy(); | ||
| } | ||
| } | ||
| } else if (!lightWeight) { | ||
| windowContext = TiContext.createTiContext(windowActivity, proxy.getTiContext().getBaseUrl(), proxy.getTiContext().getCurrentUrl()); |
There was a problem hiding this comment.
proxy.getTiContext() is used twice here and at least once below, we could make a local reference up top to avoid method calls..
|
Code review accepted |
|
Functional review also accepted. Compared with iOS behavior and it looks like we're in sync. |
|
Code Reviewed. Request Accepted. |
donthorp
added a commit
that referenced
this pull request
Aug 29, 2011
TIMOB-4345 Android: focus and blur events don't fire on window with url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-4345
This change binds the activity proxy and window proxy in the case where window has no url but is not lightweight.
The test case is the fail case in the item.
NOTE There are two commits in this pull request. The first one -- 1183a48 -- is enough to fix the problem. The second one is a refactoring of sorts in
initContext()<---- this second one should not go into 1_7_X in case we decide to fix the problem in 1_7_X, because the refactoring incurs some risk. So if we merge anything into 1_7_X for this JIRA item, only cherry-pick 1183a48. (At the moment the ticket does not say we should merge into 1_7_X, but I put this note here just in case that changes.)