[TIMOB-11269] Kitchen sink:Base UI:Window Properties->Toggling height/wi... #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/width changing opacity of window
ghost
assigned 
| { | ||
| // | ||
| // Special case where where the windowProxy arg here does not match our underlying proxy. |
…/width changing opacity of window -- fix typo in comment
…/width changing opacity of window -- Implement a cleaner solution as suggested by Ping
…/width changing opacity of window -- remove unneeded changes
…/width changing opacity of window -- remove unneeded changes
…/width changing opacity of window -- another attempt to get this right
| String propertyName = name; | ||
| Object newValue = value; | ||
|
|
||
| if (isLocaleProperty(name)) { |
There was a problem hiding this comment.
Why not put the code in the if block to a separate method in KrollProxy.java so we don't need to copy it over here?
There was a problem hiding this comment.
Should call mViewProxy.isLocaleProperty() and mViewProxy.updateLocaleProperty().
…/width changing opacity of window -- More changes in response to comments in the pull request
| String propertyName = name; | ||
| Object newValue = value; | ||
|
|
||
| updateLocalePropertyNameAndValue(propertyName, newValue); |
There was a problem hiding this comment.
Here we try to update the property of mViewProxy, so we should use mViewProxy.updateLocalePropertyNameAndValue().
…g height/width changing opacity of window -- More changes in response to comments in the pull request" This reverts commit 9298b3c.
…/width changing opacity of window -- more changes in response to comments in pull request
|
|
||
| if (mViewProxy.isLocaleProperty(name)) { | ||
| Log.i(TAG, "Updating locale: " + name, Log.DEBUG_MODE); | ||
| Pair<String, String> update = mViewProxy.updateLocaleProperty(name, value.toString()); |
There was a problem hiding this comment.
Should use TiConvert.toString(value) here and also in KrollProxy.java
…/width changing opacity of window -- more changes in response to pull request comments
|
Code reviewed and functionally tested. Ran the test case on rhino and v8 and also ran KS and Anvil for a sanity check. All passed. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Dec 19, 2012
[TIMOB-11269] Kitchen sink:Base UI:Window Properties->Toggling height/wi...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...dth changing opacity of window