Timob 11997 Padding on Table View Row #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _updatePadding: function() { | ||
| // Fake padding with a transparent border | ||
| this._contentContainer.borderWidth = this._titleLabel. borderWidth = | ||
| [this.leftImage ? 5 : 0, this.rightImage ? 5 : 0, 0, 0]; |
There was a problem hiding this comment.
We should always set a padding of 5 pixels regardless if there's a left or right image. That's what iOS does.
There was a problem hiding this comment.
iOS creates a lot of padding we don't. Only adding it some of the time makes it consistent with the rest of Mobile Web, even if it is inconsistent with iOS. We can change it once we implement the new theme that includes padding all around.
|
Code reviewed and tested. Request APPROVED. |
cb1kenobi
added a commit
that referenced
this pull request
Jan 8, 2013
Timob 11997 Padding on Table View Row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.