[TIMOB-4983] Added support for "ant install" to install a module straight #360
Conversation
| tiapp_xml = os.path.join(gen_project_dir,'tiapp.xml') | ||
|
|
||
| script = os.path.abspath(os.path.join(template_dir,'..',platform,'builder.py')) | ||
| script_args = [script, "install", manifest.name, android_sdk.get_android_sdk(), gen_project_dir, manifest.moduleid, "Necessary argument, but unused."] |
There was a problem hiding this comment.
One question I have about this commit is that last argument to the array on line 223. I haven't observed that argument having any impact on the build, but I know that if it is not there, the bounds checking will stop us with an error message. What is that argument supposed to be used for? Is it actually necessary and I missed something in my interpretation of the code? I seem to recall it being the specific Android version, or at least that's how Titanium Desktop used it.
There was a problem hiding this comment.
It's not actually needed, but it's been around since the Developer days for compatibility. we shouldn't be validating on it, that's for sure. IIRC it expects an AVD id in that argument, but AVD ids are only used for the "simulator" command
|
Ah crap... I didn't mean to do that. |
[TIMOB-4983] Added support for "ant install" to install a module straight to device.
http://jira.appcelerator.org/browse/TIMOB-4983