Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-11458] iOS: Accessibility: hide TiUIWindow when another window opens on top; send accessibility notification about screen update #3603

Merged
merged 1 commit into from Jan 7, 2013

Conversation

mstepanov
Copy link
Contributor

TIMOB-11458

Test case in JIRA. + KS Window tests

… opens on top; send accessibility notification about screen update
@vishalduggal
Copy link
Contributor

Code Reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

FR Failed?.

The test in the ticket passes but there is one behavior change which might or might not be an issue.
Basically if a window is opened and is not full screen or does not provide an explicit way to close it, the app is stuck. For example with Voice Over On try
Base UI->Window Properties->Layout/Dimension Properties.
Once the button is clicked, the app is stuck because all other elements on screen are disabled (including tabs)

REJECTED

@mstepanov
Copy link
Contributor Author

@vishalduggal I think it's expected behavior. that test is just not accessibility-friendly.

@vishalduggal
Copy link
Contributor

ok. Am accepting the PR as is. I do think we should document guidelines for good UI design for accessibility apps on iOS.

ACCEPTED

vishalduggal added a commit that referenced this pull request Jan 7, 2013
[TIMOB-11458] iOS: Accessibility: hide TiUIWindow when another window opens on top; send accessibility notification about screen update
@vishalduggal vishalduggal merged commit d46b411 into tidev:master Jan 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants