New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 12067 New and improved scrollable view #3604
Conversation
… generally cleaned up code
define(['Ti/_/browser', 'Ti/_/declare', 'Ti/_/UI/KineticScrollView', 'Ti/_/lang', 'Ti/_/dom', 'Ti/_/style', 'Ti/UI'], | ||
function(browser, declare, KineticScrollView, lang, dom, style, UI) { | ||
define(['Ti/_/browser', 'Ti/_/declare', 'Ti/UI/View', 'Ti/_/lang', 'Ti/_/dom', 'Ti/_/style', 'Ti/UI'], | ||
function(browser, declare, View, lang, dom, style, UI) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both "browser" and "lang" are no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@@ -239,7 +264,8 @@ define(['Ti/_/browser', 'Ti/_/declare', 'Ti/_/UI/KineticScrollView', 'Ti/_/lang' | |||
} | |||
|
|||
// Animate the views | |||
self._updatePagingControl(viewIndex); | |||
self._updatePagingControl(); | |||
self._showPagingControl(viewIndex); | |||
self._animateToPosition(destination, 0, duration, UI.ANIMATION_CURVE_EASE_IN_OUT, function(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_animateToPosition() does not exist because ScrollableView extends View now instead of KineticScrollView.
Code reviewed and tested. ACCEPTED |
Timob 12067 New and improved scrollable view
No description provided.