Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-10017] added null check for windowActivity #3607

Closed
wants to merge 1 commit into from

Conversation

salachi
Copy link
Contributor

@salachi salachi commented Dec 16, 2012

TIMOB-10017 - Made sure that windowActivity is not null before calling setBackgroundDrawable.
Test case is running without crash after the change

@pingwang2011
Copy link
Contributor

FR failed
Ran the test case in https://jira.appcelerator.org/browse/TIMOB-10017 . Click the button to open the second window and then click the "back" button. Click the button to open the second window again. Scroll the table view and you can see two table views overlap together. Seems like when clicking the "back" button the second window is not closed correctly and the child views are not released at all.
BTW, please add "TIMOB-xxxx" in the commit message so it's easy to find out why we do such change later.

@salachi
Copy link
Contributor Author

salachi commented Jan 24, 2013

The window doesn't get closed because the test case code keep on adding table to the window. This is a test case error. It needs to trap the android back event and cleanup the table that is added. The fix should fix the crash.

@pingwang2011
Copy link
Contributor

By clicking "back" button, the window activity should finish and the window should close and all the views in the window should be released. I attached another test case in JIRA which calls close() explicitly and you can see the same issue as I described above. I think the root of the crash is window is not closed correctly.

@pingwang2011
Copy link
Contributor

BTW, after clicking "open" and "close" buttons a few times, I can see some memory leak through DDMS which also means the window is not closed correctly and some views are not released.

@salachi
Copy link
Contributor Author

salachi commented Jan 26, 2013

I will take a look at this.

@ayeung
Copy link
Contributor

ayeung commented Jun 20, 2013

Closing due to inactivity.

@ayeung ayeung closed this Jun 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants