[TIMOB-12107] [TIMOB-12106] + misc bugs #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. [TIMOB-12106] Fixed app name validation when specified at the command line. ALSO: Added better validation of app ids, version numbers, fixed analytics where it was sending undefined instead of the icon, added more things to check for to see if a full rebuild is necessary, added --url to the create command, no longer modify the ApplicationMods.m if there are no modules, forces universal device family if device family was not specified, fixed bug with the list of params being set in the GCC_PREPROCESSOR_DEFINITIONS Xcode param, and cleaned up display of uuids when being prompted.
|
Code reviewed and tested. Request accepted |
nebrius
pushed a commit
that referenced
this pull request
Dec 22, 2012
[TIMOB-12107] [TIMOB-12106] + misc bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TIMOB-12107] Added tiapp.xml validation for id, name, guid, and version
[TIMOB-12106] Fixed app name validation when specified at the command line.
In addition: