SearchBar, SearchBar in TableView and updated separators for TableView #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back ported SearchBar, properties: autocorrect - bool barColor hinttextid prompt promptid not implemented yet.
fixed, use styles instead of creating div as separator, added searchbar support
MobileWeb: Ti.UI.SearchBar implementation
MobileWeb: Update tableview's to not create heavyweight borders
added searchbar into tableview
| setStyle = style.set, | ||
| on = require.on, | ||
|
|
||
| _calculateWidth = function(showCancel, width) { |
There was a problem hiding this comment.
This should be a function declaration, not a function expression. Also, local identifiers shouldn't start with an underscore
| var retval = []; | ||
| var tableData = []; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please ignore : 212e123, 942bcb9, - both was reverted by 134510f - there are no bad code(and final results are same) but it is more correctly to have 4 commits for these
fixed:
Jira ticket for the separator activity: https://jira.appcelerator.org/browse/TIMOB-8124
Jira ticket for "SearchBar (support in TableView)": https://jira.appcelerator.org/browse/TC-1680
Jira issue for "SearchBar" change: https://jira.appcelerator.org/browse/TIMOB-7231
Jira issue for "Sections+Headers" change: https://jira.appcelerator.org/browse/TC-1580