timob-11653: expose error stack trace #3685
Conversation
| } | ||
| } | ||
|
|
||
| } else if (jsValue->IsString()) { |
There was a problem hiding this comment.
Maybe we can also handle numbers as well?
|
If we want to have a line number property, we can probably just parse it from the stack trace. It looks like they have a standard format that won't change much: http://code.google.com/p/v8/wiki/JavaScriptStackTraceApi We may want to include a file name, and other properties as well, if we end up parsing it. |
| } | ||
| } | ||
|
|
||
| } else { |
There was a problem hiding this comment.
Does this handle the case where it's something like an array, 'null', or 'undefined'? If not, we probably don't want to do an else here. We might just want to do this for cases where this jsValueToJavaString() actually works.
There was a problem hiding this comment.
jsValueToJavaString() is merely calling jsValue->ToString() with a null check. I've tested with all cases you mentioned. If its an array, or null, null is returned for the KrollException. If it's undefined, a valid KrollException is returned with the message being undefined. I think these are acceptable results.
|
Code reviewed. Please address comments. |
|
Code updated. Ready for re-review |
| @@ -0,0 +1,66 @@ | |||
| /** | |||
| * Appcelerator Titanium Mobile | |||
| * Copyright (c) 2012 by Appcelerator, Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
This should be 2012-2013 now =)
|
Code reviewed. Besides the license change, Request Accepted |
|
Code reviewed and functionally tested. Request Accepted |
timob-11653: expose error stack trace
test case in JIRA: https://jira.appcelerator.org/browse/TIMOB-11653