timob-11762: imageView should update images correctly #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1039,12 +1035,16 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP | |||
| } else if (key.equals(TiC.PROPERTY_ENABLE_ZOOM_CONTROLS)) { | |||
| view.setEnableZoomControls(TiConvert.toBoolean(newValue)); | |||
| } else if (key.equals(TiC.PROPERTY_IMAGE)) { | |||
| setImageSource(newValue); | |||
| if (oldValue.equals(newValue)) { | |||
There was a problem hiding this comment.
Should use "==" here instead of .equals(), because we are trying to check if two object reference variables refer to the exact same instance of an object.
There was a problem hiding this comment.
They're basically the same thing. http://stackoverflow.com/questions/7520432/java-vs-equals-confusion
There was a problem hiding this comment.
You are right. equals() is more appropriate here, because we only care whether the value of the two objects are the same not the object itself.
|
Code reviewed and functionally tested. Ran the test case and KS->TableView/ImageView. All passed. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Jan 11, 2013
timob-11762: imageView should update images correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing steps in JIRA: https://jira.appcelerator.org/browse/TIMOB-11762