[TIMOB-12127] Upgraded Uglify from v1 to v2. Added uglify error handling... #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to mobile web's build.
| @@ -2281,21 +2274,27 @@ build.prototype = { | |||
|
|
|||
| findSymbols: function (ast) { | |||
There was a problem hiding this comment.
Is this just finding variable/function identifiers? If so, you can accomplish it a lot easier using figure_out_scope. http://lisperator.net/uglifyjs/scope
There was a problem hiding this comment.
Hmm, I'll try playing around with the scope stuff tomorrow.
…y function calls but property calls too.
| this.logger.error(__('%s', ex.message)); | ||
| } | ||
| try { | ||
| var contents = fs.readFileSync(source).toString().split('\n'); |
There was a problem hiding this comment.
I think we can move this read inside the if statement, that way we don't have to read the file if we don't have a line. Also, what about windows newlines?
There was a problem hiding this comment.
Won't fix. Contents is needed to check if the line # is valid.
|
Code reviewed and tested. Request accepted |
nebrius
pushed a commit
that referenced
this pull request
Jan 22, 2013
[TIMOB-12127] Upgraded Uglify from v1 to v2. Added uglify error handling...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to mobile web's build.