iOS: optimize relayout queue #3751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove useless relayout in queue, all subviews are useless when performing performLayoutRefresh, only root views will be relayout.
|
Thank you for your commit. We need a ticket associated with each pull request so it can be properly tested. Can you please create one or find one as mentioned in the pull request guide? |
|
TIMOB-10493 does not appear to be the correct ticket for this pull request as that ticket is about DashboardView and this PR is about relayout queue optimization. Can you please provide the correct ticket number? |
|
Thank you for the contribution. We are currently hesitant to accept this patch because we suspect it may not improve performance. Given that there is no JIRA ticket created since my last comment, I will close this patch for now. You are welcome to submit an updated version again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove useless relayout in queue,
all subviews are useless when performing performLayoutRefresh,
only root views will be relayout.