TIMOB-12286: Android: Memory leak when backing out and coming back to an app #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2013 11:42
… context already returns a presistent handle.
…e into timob-12286
…e into timob-12286
…als to be accessible as mentioned in TIMOB-11752
| @@ -107,7 +107,7 @@ class NativeObject | |||
| assert(value == obj->handle_); | |||
| assert(!obj->refs_); | |||
| assert(value.IsNearDeath()); | |||
| delete obj; | |||
| // delete obj; | |||
There was a problem hiding this comment.
I don't like leaving this delete commented out. I recall it was causing a crash, but we should figure out the cause and fix it properly.
|
Functionally tested. Ran test cases in TIMOB-12286 and TIMOB-11752 and also ran KS as a sanity test. All passed. FR Accepted |
|
Josh has already reviewed the code and accepted the request. |
pingwang2011
added a commit
that referenced
this pull request
Jan 29, 2013
TIMOB-12286: Android: Memory leak when backing out and coming back to an app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-12286
This pull request makes it so we no longer wrap our global context inside a persistent handle. This would cause a memory leak since it would never get cleaned up. Modules also no longer create a new context when they are created. Instead, they use the existing context and TiInclude was also changed to do the same.
Please run test case in TIMOB-12286, TIMOB-11752, and also do a pass of KS.